Skip to content

ZA Cape Town | ITP-May-2025 | Dawud Vermeulen | Sprint 3 | Reading-List #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Dave-Vermeulen
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

changed the reading list script.js and the index.html files for this build. works well and past all test.

Questions

Please review my code and let me know if any changes are required.

@Dave-Vermeulen Dave-Vermeulen added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 5, 2025

books.forEach(book => {
const listItem = document.createElement('li'); // for each book, create a list item
listItem.style.backgroundColor = book.alreadyRead ? 'green' : 'red'; // set background color based on alreadyRead status
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code works as intended. However, it's recommended to use css classes to modify the styles. You don't have to change the code here tho.

@day-lee
Copy link

day-lee commented Aug 7, 2025

Well done! Your code passes all tests, so it's good to go!

@day-lee day-lee added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Volunteer to add when work is complete and all review comments have been addressed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants